Delete all old dag pages and redirect to grid view #37988
Conversation
boring-cyborg
bot
added
area:UI
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Whohooo! Cool! Finally! (I just need to get used to the "missing top bar" - so much more space on the screen - but will take a moment until I take the new alternative buttons.
I'd approve but have a small request for consistency of beautification: There are 3,5 screens leftover in the old structure:
- Grid/Task Details --> More Details (still pointing to a legacy view, which actually is just a small leftover to migrate... wanted to contribute this but never came out of my backlog :-()
- Grid/Task Details --> Rendered Template (same here)
- Grid/Logs --> See more
If you click on any of these you end-up on the legacy view with the leftovers, still there is a top navigation, besides the browser back button there is no way to "officially" get back to Grid view. Also the legacy XCom is these.
Can you please add a button to get back to Grid view?
Would it make sense to drop the XCom view here as well? The new one is there anyway.
(Alternatively, wouls it be simple to migrate at elast the two "More Details/Rendered Template" also into React? Old Log view might stay there, at least I am a fan of the full screen option still from old times... sometimes logs in Grid are too small)
Yes, I need to add rendered templates to React and then remove these pages too. |
bbovenzi
force-pushed
the
remove-legacy-dag-pages
branch
from
a4b3a92 to
0b6ea34
Compare
|
Ready to test to get it into 2.9.0? |
bbovenzi
force-pushed
the
remove-legacy-dag-pages
branch
from
27e903f to
b4998d7
Compare
bbovenzi
requested review from
ashb,
pierrejeambrun and
ryanahamilton
as code owners
Yep! Ready for review now. |
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I was hoping that the last two pages are also replaced with the last commit as notes in #37988 (review) - but LGTM before having this waiting until 2.10 - leftovers can also be made in a follow-up PR...
Which last two pages are you referring to? Finishing off the task specific ones like |
bbovenzi
force-pushed
the
remove-legacy-dag-pages
branch
from
bc59e52 to
72c8b7d
Compare
Lee-W
force-pushed
the
remove-legacy-dag-pages
branch
from
72c8b7d to
2d733d0
Compare
bbovenzi
force-pushed
the
remove-legacy-dag-pages
branch
from
2d733d0 to
61bcfbf
Compare
|
@bbovenzi i think this one really wants a news fragment. some users are gonna be "where did my buttons go???" |
bbovenzi
force-pushed
the
remove-legacy-dag-pages
branch
from
7081bcc to
5fee0d2
Compare
|
Finally.. WOHOOO! Thanks! |
The code that used it was removed in apache#37988 already. It was used in FAB views.
The code that used it was removed in #37988 already. It was used in FAB views.
The code that used it was removed in apache#37988 already. It was used in FAB views.
The code that used it was removed in apache/airflow#37988 already. It was used in FAB views. GitOrigin-RevId: 10c6464d86adc7e3d74677065b892722e2c09238
The code that used it was removed in apache/airflow#37988 already. It was used in FAB views. GitOrigin-RevId: 10c6464d86adc7e3d74677065b892722e2c09238
The code that used it was removed in apache/airflow#37988 already. It was used in FAB views. GitOrigin-RevId: 10c6464d86adc7e3d74677065b892722e2c09238
7 participants
All of the DAG pages are in React now, so we can delete the old FAB templates and redirect the urls to the grid view and appropriate tab. This removes extraneous vertical space on the page too.
Landing Times -> Run Duration
Task Duration -> Task Duration
Audit Log -> Audit Log
Calendar -> Calendar
Task Tries -> Grid (this never made sense as a line chart, instead try_number is displayed in more places)
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.